Re: [PATCH] esx: Explictly declare VMX file content as UTF-8

Matthias Bolte <matthias.bolte@xxxxxxxxxxxxxx> · Fri, 15 Oct 2010 20:45:04 +0200

2010/10/14 Daniel Veillard <veillard@xxxxxxxxxx>:
> On Thu, Oct 14, 2010 at 08:59:18AM +0200, Matthias Bolte wrote:
>> ---
>> Âsrc/esx/esx_vmx.c Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â| Â Â3 +++
>> Âtests/xml2vmxdata/xml2vmx-annotation.vmx Â Â Â Â Â | Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-cdrom-ide-device.vmx Â Â | Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-cdrom-ide-file.vmx Â Â Â | Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-cdrom-scsi-device.vmx Â Â| Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-cdrom-scsi-file.vmx Â Â Â| Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-esx-in-the-wild-1.vmx Â Â| Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-esx-in-the-wild-2.vmx Â Â| Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-esx-in-the-wild-3.vmx Â Â| Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-esx-in-the-wild-4.vmx Â Â| Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-ethernet-bridged.vmx Â Â | Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-ethernet-custom.vmx Â Â Â| Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-ethernet-e1000.vmx Â Â Â | Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-ethernet-generated.vmx Â | Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-ethernet-other.vmx Â Â Â | Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-ethernet-static.vmx Â Â Â| Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-ethernet-vmxnet2.vmx Â Â | Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-ethernet-vpx.vmx Â Â Â Â | Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-floppy-device.vmx Â Â Â Â| Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-floppy-file.vmx Â Â Â Â Â| Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-graphics-vnc.vmx Â Â Â Â | Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-gsx-in-the-wild-1.vmx Â Â| Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-gsx-in-the-wild-2.vmx Â Â| Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-gsx-in-the-wild-3.vmx Â Â| Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-gsx-in-the-wild-4.vmx Â Â| Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-harddisk-ide-file.vmx Â Â| Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-harddisk-scsi-file.vmx Â | Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-minimal-64bit.vmx Â Â Â Â| Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-minimal.vmx Â Â Â Â Â Â Â| Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-parallel-device.vmx Â Â Â| Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-parallel-file.vmx Â Â Â Â| Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-scsi-driver.vmx Â Â Â Â Â| Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-scsi-writethrough.vmx Â Â| Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-serial-device.vmx Â Â Â Â| Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-serial-file.vmx Â Â Â Â Â| Â Â1 +
>> Â.../xml2vmxdata/xml2vmx-serial-network-client.vmx Â| Â Â1 +
>> Â.../xml2vmxdata/xml2vmx-serial-network-server.vmx Â| Â Â1 +
>> Âtests/xml2vmxdata/xml2vmx-serial-pipe.vmx Â Â Â Â Â| Â Â1 +
>> Â38 files changed, 40 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/esx/esx_vmx.c b/src/esx/esx_vmx.c
>> index e17e1e7..7dc8e60 100644
>> --- a/src/esx/esx_vmx.c
>> +++ b/src/esx/esx_vmx.c
>> @@ -2475,6 +2475,9 @@ esxVMX_FormatConfig(esxVMX_Context *ctx, virCapsPtr caps, virDomainDefPtr def,
>> Â Â Â Â Âreturn NULL;
>> Â Â Â}
>>
>> + Â Â/* vmx:.encoding */
>> + Â ÂvirBufferAddLit(&buffer, ".encoding = \"UTF-8\"\n");
>> +
>> Â Â Â/* vmx:config.version */
>> Â Â ÂvirBufferAddLit(&buffer, "config.version = \"8\"\n");
>>
>
> ÂGood idea ! Nice that they though about the need for an encoding there,
>
> ACK
>
> Now the question is do we check for encoding when reading a vmx ?
> Some iconv (or maybe we can reuse libxml2 conversion functions) might
> be in order.
>
> Daniel

We currently assume that VMX files are UTF-8 encoded (that's true for
ESX, at least I didn't find a counter example yet), but for example a
Windows based GSX server uses Windows-1252 encoding by default. This
is denoted as .encoding = "windows-1252" in the VMX file.

I'm working on it.

Thanks, pushed.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list