On 10/14/2010 01:06 PM, Mitchell Hashimoto wrote:
Daniel,
Thanks for your response, I appreciate it. The `grep` on the two
Makefiles is equivalent. I've uploaded a diff of the two Makefiles
here: https://gist.github.com/da0e93a335be6a3a637b Let me know if you
want me to upload the actual Makefiles as well, since I can do that.
Can you provide a context diff (diff -u or diff -c) rather than an
ed-script diff? Context can be essential in a review.
At any rate:
< # Makefile.in generated by automake 1.9.6 from Makefile.am.
---
> # Makefile.in generated by automake 1.11.1 from Makefile.am.
Is this stock automake 1.9.6, or does it have a distro patch to fix
CVE-2009-4029? Using an older automake may be the root cause of
remaining problems, if we are relying on a feature that only automake
1.10 or 1.11 provides.
What is 'automake --version' for you, and did you generate the tarballs,
or is the automake 1.9.6 on someone else's machine?
< $(top_srcdir)/m4/nls.m4 $(top_srcdir)/m4/po.m4 \
< $(top_srcdir)/m4/progtest.m4 $(top_srcdir)/m4/size_max.m4 \
< $(top_srcdir)/m4/wchar_t.m4 $(top_srcdir)/m4/wint_t.m4 \
< $(top_srcdir)/m4/xsize.m4 $(top_srcdir)/acinclude.m4 \
< $(top_srcdir)/configure.ac
---
> $(top_srcdir)/m4/libtool.m4 $(top_srcdir)/m4/ltoptions.m4 \
> $(top_srcdir)/m4/ltsugar.m4 $(top_srcdir)/m4/ltversion.m4 \
> $(top_srcdir)/m4/lt~obsolete.m4 $(top_srcdir)/m4/nls.m4 \
> $(top_srcdir)/m4/po.m4 $(top_srcdir)/m4/progtest.m4 \
> $(top_srcdir)/m4/size_max.m4 $(top_srcdir)/m4/wchar_t.m4 \
> $(top_srcdir)/m4/wint_t.m4 $(top_srcdir)/m4/xsize.m4 \
> $(top_srcdir)/acinclude.m4 $(top_srcdir)/configure.ac
Why the difference in which libtool .m4 files are provided?
< configure.lineno configure.status.lineno
---
> configure.lineno config.status.lineno
There's no such file as configure.status.lineno; but that's attributable
to a bug in the older automake that has since been fixed.
I've stopped looking at this point.
--
Eric Blake eblake@xxxxxxxxxx +1-801-349-2682
Libvirt virtualization library http://libvirt.org
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list