On Tue, Sep 28, 2010 at 03:26:30PM +0530, Nikunj A. Dadhania wrote: > From: Nikunj A. Dadhania <nikunj@xxxxxxxxxxxxxxxxxx> > > Adding parsing code for memory tunables in the domain xml file > > v2: > + Fix typo min_guarantee > > Signed-off-by: Nikunj A. Dadhania <nikunj@xxxxxxxxxxxxxxxxxx> > --- > src/conf/domain_conf.c | 50 +++++++++++++++++++++++++++++++++++++------- > src/conf/domain_conf.h | 12 ++++++++--- > src/esx/esx_vmx.c | 30 +++++++++++++------------- > src/lxc/lxc_controller.c | 2 +- > src/lxc/lxc_driver.c | 12 +++++------ > src/openvz/openvz_driver.c | 8 ++++--- > src/qemu/qemu_conf.c | 8 ++++--- > src/qemu/qemu_driver.c | 18 ++++++++-------- > src/test/test_driver.c | 12 +++++------ > src/uml/uml_conf.c | 2 +- > src/uml/uml_driver.c | 14 ++++++------ > 11 files changed, 104 insertions(+), 64 deletions(-) ACK, looks fine, though it'd be good to add one or two example data files to tests/qemuxml2xmltest.c to ensure that we roundtrip through the XML parser+formatter correctly. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list