On Wed, Sep 29, 2010 at 11:25:31AM +0200, Gerhard Stenzel wrote:
> Hi Daniel,
> I am currently looking into TCK test cases to verify setting 802.1Qbg
> functionality from libvirt. My current approach requires changes to some
> library functions in lib/Sys/Virt/TCK/.
> I would appreciate your feedback about these changes before continuing
> much further.
> Index: libvirt-tck/lib/Sys/Virt/TCK/NetworkHelpers.pm
> ===================================================================
> --- libvirt-tck.orig/lib/Sys/Virt/TCK/NetworkHelpers.pm
> +++ libvirt-tck/lib/Sys/Virt/TCK/NetworkHelpers.pm
> @@ -50,10 +50,21 @@ sub build_domain{
> my $filterref = "clean-traffic";
> my $network = "network";
> my $source = "default";
> + my $dev = "eth2";
> + my $mode;
> + my $virtualport;
>
> my ($cdrom, $ksurl) = build_cdrom_ks_image($tck);
>
> my $guest = $tck->generic_domain($domain_name);
> +
> + # change the type of network connection for 802.1Qbg tests
> + if ($domain_name =~ "8021Qbg") {
I don't like this approach. JUst add an optional parameter
to the build_domain methods
my $mode = @_ ? shift : "bridge";
eg so it default to traditional bridging, but you can pass
in 'vepa' if you desire to change it. Or something like
that.
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list