Re: [PATCH] xen: Fix bogus error when attaching a device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> >       default:
> > -        xenXMError(VIR_ERR_XML_ERROR,
> > -                   "%s", _("unknown device"));
> > +        xenXMError(VIR_ERR_OPERATION_INVALID, "%s",
> > +                   _("Xm driver only supports adding disk or network devices"));
> >           goto cleanup;
> >       }
> >
> 
> It looks like many other similar errors in other drivers use 
> VIR_ERR_CONFIG_UNSUPPORTED. Would that maybe be a better choice than 
> VIR_ERR_OPERATION_INVALID

Yeah, right, I guess it's not worth a v2, is it?

Jirka

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]