Re: [PATCH] phyp: Verify that domain XML contains at least one disk element

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/9/30 Eric Blake <eblake@xxxxxxxxxx>:
> On 09/30/2010 01:18 PM, Matthias Bolte wrote:
>>
>> phypBuildLpar expects that at least one disk element is provided.
>> ---
>> Âsrc/phyp/phyp_driver.c | Â 18 +++++++++++-------
>> Â1 files changed, 11 insertions(+), 7 deletions(-)
>>
>> diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
>> index ab12392..0a7d6f9 100644
>> --- a/src/phyp/phyp_driver.c
>> +++ b/src/phyp/phyp_driver.c
>> @@ -3715,13 +3715,17 @@ phypBuildLpar(virConnectPtr conn, virDomainDefPtr
>> def)
>> Â Â Â Â Âgoto err;
>> Â Â Â}
>>
>> - Â Âif (def->ndisks> Â0) {
>> - Â Â Â Âif (!def->disks[0]->src) {
>> - Â Â Â Â Â ÂPHYP_ERROR(VIR_ERR_XML_ERROR,"%s",
>> - Â Â Â Â Â Â Â Â Â Â_("Field \"<src>\" under \"<disk>\" on the domain XML
>> file is "
>> - Â Â Â Â Â Â Â Â Â Â Â Â"missing."));
>> - Â Â Â Â Â Âgoto err;
>> - Â Â Â Â}
>> + Â Âif (def->ndisks< Â1) {
>> + Â Â Â ÂPHYP_ERROR(VIR_ERR_XML_ERROR, "%s",
>> + Â Â Â Â Â Â Â Â Â _("Domain XML must contain at least one \"<disk>\"
>> element."));
>> + Â Â Â Âgoto err;
>> + Â Â}
>
> ACK.
>

Thanks, pushed.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]