Re: nwfilter: Don't compile nwfilter driver on other systems than Linux

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/27/2010 12:02 PM, Stefan Berger wrote:
Don't compile the nwfilter driver (instantiating the rules) on other
systems than Linux.

Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxx>

diff --git a/configure.ac b/configure.ac
index 23181dd..4cb0f50 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1361,7 +1361,7 @@ fi
AM_CONDITIONAL([WITH_SECRETS], [test "$with_secrets" = "yes"])

with_nwfilter=yes
-if test "$with_libvirtd" = "no"; then
+if test "$with_libvirtd" = "no" || test `uname -s` != "Linux"; then

NACK as written.  This would fail when cross-compiling.

Instead, you should check $host or $host_os.

Hmm, configure.ac already has an AM_CONDITIONAL for WITH_LINUX; which means $with_linux is also a reasonable thing to check.

--
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]