> > @@ -7903,52 +7904,40 @@ cmdAttachInterface(vshControl *ctl, const vshCmd *cmd) > > } > > > > /* Make XML of interface */ > > - tmp = vshMalloc(ctl, 1); > > - buf = vshMalloc(ctl, strlen(type) + 25); > > - sprintf(buf, "<interface type='%s'>\n" , type); > > + virBufferVSprintf(&buf, "<interface type='%s'>\n" , type); > > Weird spacing before the second comma Oops, I didn't notice this weirdness in the original code and let it slip into the new one. I fixed that and pushed, thanks. Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list