On Tue, Jul 13, 2010 at 09:41:42PM -0400, Stefan Berger wrote: > Any comments regarding this patch? > > V2: > - Following Daniel Berrange's suggestions > - if LIBVIRT_TCK_CONFIG is set, read the last occurrence of "^uri/s=" and assign the value to LIBVIRT_URI > - check that LIBVIRT_URI is set to qemu:///system, otherwise skip test > - if allowed, remove all VMs and nwfilters starting with tck- > - rename all VMs and nwfilters created by this test program to start with 'tck-' > - other: > - terminate if sourcing the test-lib.sh from libvirt's tests dir is missing (would need to be copied) > - redirect stderr to stdout whereever output is read into a variable Sorry I completely forgot about this. I've now tested it and with a couple of minor fixes it works fine. I just had to tweak the way it extracted the libvirt uri from the tck config, and remove the hardcoded paths to libvirtd/virsh that expect a source tree. The TCK is designed to run an installed system. If it is desired to run against an install tree, those can just be added to $PATH & libvirtd started ahead of time. I've committed the patch & pushed it to GIT Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list