2010/9/1 Eric Blake <eblake@xxxxxxxxxx>: > On 09/01/2010 09:32 AM, Matthias Bolte wrote: >> >> That's a bit tricky. In case Parameter.get_type_string() is called >> from Parameter.generate_return() then >> >> string += "%s*%s)%s" % (self.get_type_string(), self.name, end_of_line) >> >> in line 104 adds the second *. >> >> I attached v2 where this is simplified. > > Yes, it's much easier to see in v2. ACK, if you trust my minimal python > reviewing skills. > Well, your first review already improved the patch :) Thanks, pushed v2. Matthias -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list