Re: [PATCH 4/7] network: use virAsprintf when appropriate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/01/2010 03:20 PM, Matthias Bolte wrote:
2010/9/1 Eric Blake<eblake@xxxxxxxxxx>:
* src/conf/network_conf.c (virNetworkAllocateBridge): Avoid
limited buffer from snprintf.
---

Why print to a fixed-width buffer to then just strdup it later,
when we can print to a malloc'd buffer in the first place.  Besides,
I couldn't easily guarantee if the buffer was large enough or if
it would contain arbitrary user input.


ACK.

Thanks; pushed.

--
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]