Re: [PATCH] virsh: remove driver check from attach-disk command

[Eric Blake <eblake@xxxxxxxxxx>]

On 08/24/2010 10:09 AM, Ryan Harper wrote:
> Virsh shouldn't check for driver support but rather let the backend handled this.
> After removing the check, I can successfully attach file-based images to a qemu
> VM with attach-disk.
>
>
>       if (driver) {
> -        if (STREQ(driver, "file") || STREQ(driver, "tap")) {
> +        if (STREQ(driver, "file") || STREQ(driver, "tap"))
>               isFile = 1;
> -        } else if (STRNEQ(driver, "phy")) {
> -            vshError(ctl, _("No support for %s in command 'attach-disk'"),
> -                     driver);
> -            goto cleanup;
> -        }
>       }

ACK; pushed.

--
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list