2010/8/24 Soren Hansen <soren@xxxxxxxxxx>: > On 24-08-2010 22:20, Matthias Bolte wrote: >>> + if (ret < 0) >>> + goto error; >> >> I was about to push this patch, but compile testing gave this error: >> >> uml/uml_driver.c: In function 'umlDomainAttachUmlDisk': >> uml/uml_driver.c:1729: error: 'ret' may be used uninitialized in this >> function [-Wuninitialized] >> >> I think "if (ret < 0) goto error;" and "int ret;" can just be removed >> completely from this function, but I would like have your ACK on this >> before doing so. > > Please do so. I haven't a clue where that came from, and due to the > magic of having git rebased every time, I'll never know. :) > Okay, removed the offending code and pushed the result. Matthias -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list