[PATCH] nodeinfotest: Print libvirt error on failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



If linuxNodeInfoCPUPopulate() fails, the test would just print "FAILED"
which is not very informative. It's better to print the real error.
---
 tests/nodeinfotest.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/tests/nodeinfotest.c b/tests/nodeinfotest.c
index d3c500d..d256c53 100644
--- a/tests/nodeinfotest.c
+++ b/tests/nodeinfotest.c
@@ -43,6 +43,12 @@ static int linuxTestCompareFiles(const char *cpuinfofile, const char *outputfile
 
     memset(&nodeinfo, 0, sizeof(nodeinfo));
     if (linuxNodeInfoCPUPopulate(cpuinfo, &nodeinfo) < 0) {
+        if (virTestGetDebug()) {
+            virErrorPtr error = virSaveLastError();
+            if (error && error->code != VIR_ERR_OK)
+                fprintf(stderr, "\n%s\n", error->message);
+            virFreeError(error);
+        }
         fclose(cpuinfo);
         return -1;
     }
-- 
1.7.2

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]