Re: [PATCH 05/10] storage: avoid s[n]printf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/19/2010 03:10 PM, Matthias Bolte wrote:
> 2010/8/19 Eric Blake <eblake@xxxxxxxxxx>:
>> * src/storage/storage_backend.c (virStorageBackendCreateQemuImg)
>> (virStorageBackendCreateQcowCreate): Use virAsprintf instead.
>> * src/storage/storage_backend_disk.c
>> (virStorageBackendDiskCreateVol, virStorageBackendDiskPartFormat):
>> Likewise.
>> ---
>>
>> Things to look out for:
>> virStorageBackendDiskPartFormat can now fail where it used to
>> do nothing to the passed-in partFormat variable, if the switch
>> statement hits the default.
>>
> 
> Nice one, before it would just have executed parted with a random
> string in the argumentlist in that case.
> 
> ACK.

Thanks; pushed.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]