2010/8/19 Eric Blake <eblake@xxxxxxxxxx>: > * src/vbox/vbox_tmpl.c (vboxDomainCreateWithFlags): Split... > (vboxStartMachine): ...into new helper. > --- > > This function was just too unbearable with that much nested indentation. > This should be a no-op refactoring. Looks fine and I can still start a VirtualBox guest after applying this patch. > vboxDomainDefineXML is even worse, and contains the remaining sprintf > instances in this file; I'll probably try to factor that one down as well. Yes, unfortunately the driver code has many indentation levels and large functions in several places. ACK. Matthias -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list