On 08/19/2010 08:47 AM, Jiri Denemark wrote:
> ---
> src/qemu/qemu_monitor_json.c | 9 ++-------
> 1 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
> index e8609aa..8a586bc 100644
> --- a/src/qemu/qemu_monitor_json.c
> +++ b/src/qemu/qemu_monitor_json.c
> @@ -1481,17 +1481,12 @@ int qemuMonitorJSONSetMigrationDowntime(qemuMonitorPtr mon,
> unsigned long long downtime)
> {
> int ret;
> - char *downtimestr;
> virJSONValuePtr cmd;
> virJSONValuePtr reply = NULL;
> - if (virAsprintf(&downtimestr, "%llums", downtime) < 0) {
> - virReportOOMError();
> - return -1;
> - }
> +
> cmd = qemuMonitorJSONMakeCommand("migrate_set_downtime",
> - "s:value", downtimestr,
> + "d:value", downtime / 1000.0,
Does "d:value" correctly handle an unsigned long long argument passed
through varargs? I'm thinking you either need a modifier in
qemuMonitorJSONMakeCommand that knows how to receive long long
arguments, or you need a cast here to pass the correct integer type.
--
Eric Blake eblake@xxxxxxxxxx +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list