On 08/18/2010 02:32 AM, Daniel P. Berrange wrote: >> Don't get me wrong, I don't think this is a killer feature. But when I >> initially implemented compression, I definitely would have done it through >> the API if we had had a "flags" parameter available for virDomainSave(). Now >> that we have a ManagedSave that does have a flags parameter, I figured we do >> it the right way. I think it's a little cleaner, and more intuitive, to do >> it through the API, and it makes the feature available to hypervisors other >> than qemu. > > I still can't imagine anyone needing the ability to specify a different > compression method per-guest VM. Perhaps a VIR_SAVE_COMPRESS to toggle > compression on / off, with actual type of compression determined in the > host config, but anything more seems rather overkill. But where is the host config for hypervisors other than qemu? Having only a compress/no-compress toggle makes sense as a reasonable compromise to me, if we know how to let the user specify the preferred compression type for all hypervisors. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list