Re: [PATCH 4/5] nodedev: Free the right pointers when getting WWNs fails

[Dave Allan <dallan@xxxxxxxxxx>]

On Tue, Aug 17, 2010 at 10:51:47PM +0200, Jiri Denemark wrote:
> ---
>  src/conf/node_device_conf.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
> index 6583570..0b080ce 100644
> --- a/src/conf/node_device_conf.c
> +++ b/src/conf/node_device_conf.c
> @@ -1283,8 +1283,8 @@ virNodeDeviceGetWWNs(virNodeDeviceDefPtr def,
>          ret = -1;
>      } else if (*wwnn == NULL || *wwpn == NULL) {
>          /* Free the other one, if allocated... */
> -        VIR_FREE(wwnn);
> -        VIR_FREE(wwpn);
> +        VIR_FREE(*wwnn);
> +        VIR_FREE(*wwpn);
>          ret = -1;
>          virReportOOMError();
>      }
> -- 
> 1.7.2
> 
> --
> libvir-list mailing list
> libvir-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/libvir-list

ACK

Dave

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list