On Mon, Aug 16, 2010 at 10:21:31AM -0600, Eric Blake wrote: > On 08/13/2010 09:06 AM, Daniel P. Berrange wrote: > > On Fri, Aug 13, 2010 at 10:53:48AM -0400, Chris Lalancette wrote: > >> Add in the ability to specify compression flags from the > >> managed save API. We map these to the supported QEMU > >> compression flags internally. > > > > I'm not really convinced we need todo this. I think the host > > level setting in /etc/libvirt/qemu.conf is sufficient already. > > But that's a global setting for all qemu domains. I can see where it > might make sense to compression for some domains but not others, at > which point exposing the ability to suggest a non-default compression > makes sense. I know that's a global setting. IMHO setting compression per VM is a feature in search of a problem. > On the other hand, if we agree that a qemu.conf setting is adequate, > then this patch still needs a respin, in order to honor the conf-file > default rather than hard-coding it to raw. Yes, that's a serious bug in the current code. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list