On Fri, Aug 13, 2010 at 02:44:38PM -0600, Eric Blake wrote:
> Incomplete subject line? It used to be
> nwfilter: extend nwfilter reload support
>
> On 08/13/2010 02:29 PM, Stefan Berger wrote:
> > v3:
> > - Fixed an indentation problem
> > - added bool parameter to function terminating the IP address
> > learner threads to determine whether future threads may still run
> > (needed in case of driver reload) or all must terminate (need in case of
> > libvirtd termination)
> >
>
> > + conn = virConnectOpen("qemu:///system");
> > +
> > + if (conn) {
> > + /* shut down all threads -- qemud for example will restart them */
> > + virNWFilterLearnThreadsTerminate(true);
> > +
> > + nwfilterDriverLock(driverState);
> > + virNWFilterPoolLoadAllConfigs(conn,
> > + &driverState->pools,
>
> Indentation problem still looks like it is here.
>
> > @@ -1912,7 +1926,11 @@ qemudStartup(int privileged) {
> > 1, NULL, NULL) < 0)
> > goto error;
> >
> > - qemuReconnectDomains(qemu_driver);
> > + conn = virConnectOpen(qemu_driver->privileged ?
> > + "qemu:///system" :
> > + "qemu:///session");
>
> How come this one is conditional, but the other one was hard-coded to
> system?
The 'nwfilter' driver is only run when it is privileged,
totally disabled otherwise. The QEMU driver runs privileged
and unprivilegd. So this difference is ok
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list