Re: [PATCH v2] esx: Explicitly disable unused floppy devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/8/14 Eric Blake <eblake@xxxxxxxxxx>:
> On 08/11/2010 05:13 PM, Matthias Bolte wrote:
>> floppy0.present defaults to true. Therefore, it needs to be
>> explicitly set to false when the XML config doesn't specify the
>> corresponding floppy device.
>> ---
>>
>> v2:
>> - This issue affects ESX too, the assumed default was wrong in
>>   general
>> - Explicitly disable unused floppy devices independent of the
>>   product version
>>
>>  src/esx/esx_vmx.c |   19 +++++++++++++++----
>>  src/esx/esx_vmx.h |    2 +-
>>  2 files changed, 16 insertions(+), 5 deletions(-)
>
> ACK.
>

Thanks.

But this patch is incomplete. I missed to update the xml2vmx test data files.

I've added a bunch of floppy0.present = "false" and floppy1.present =
"false" lines to the test files and pushed the result.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]