On 08/13/2010 12:28 PM, Stefan Berger wrote: > Fixing a memory leak. > > Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxx> > > --- > src/nwfilter/nwfilter_ebiptables_driver.c | 3 +++ > 1 file changed, 3 insertions(+) > > Index: libvirt-acl/src/nwfilter/nwfilter_ebiptables_driver.c > =================================================================== > --- libvirt-acl.orig/src/nwfilter/nwfilter_ebiptables_driver.c > +++ libvirt-acl/src/nwfilter/nwfilter_ebiptables_driver.c > @@ -2973,6 +2973,9 @@ static int ebtablesCleanAll(const char * > ebtablesRemoveTmpRootChain(&buf, 0, ifname); > > ebiptablesExecCLI(&buf, &cli_status); > + > + virBufferFreeAndReset(&buf); > + NACK. ebiptablesExecCLI already frees the buffer whether it succeeds or fails; that is, by calling ebiptablesExecCLI, you have given up ownership of buf and there is nothing left to free. What makes you think this is a leak? -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list