On Mon, Aug 09, 2010 at 04:44:14PM -0600, Eric Blake wrote:
> On 08/05/2010 06:45 PM, Matthias Bolte wrote:
> > floppy0.present defaults to true for GSX. Therefore, it needs to be
> > explicitly disabled for GSX.
> > ---
> > src/esx/esx_vmx.c | 10 ++++++++++
> > 1 files changed, 10 insertions(+), 0 deletions(-)
>
> If I understand correctly, you want to uniformly make floppy not present
> except when the user asked for it. The other ESX clients meet this
> goal, but for GSX, you have to add an extra argument to make it so.
> That being the case, I agree with the approach.
>
> > @@ -2539,6 +2544,11 @@ esxVMX_FormatConfig(esxVMX_Context *ctx, virCapsPtr caps, virDomainDefPtr def,
> > }
> > }
> >
> > + if (!hasFloppyDevice && productVersion & esxVI_ProductVersion_GSX) {
>
> I'd add an extra () here to make precedence clear:
>
> if (!hasFloppyDevice && (productVersion & esxVI_ProductVersion_GSX)) {
>
> ACK with that nit fixed.
Agreed, ACK
Matthias you push it ?
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list