On Mon, Jul 26, 2010 at 09:53:34AM -0700, Chris Wright wrote: > * Daniel Veillard (veillard@xxxxxxxxxx) wrote: > > On Fri, Jul 23, 2010 at 11:03:47PM -0700, Chris Wright wrote: > > > When doing a PCI secondary bus reset, we must be sure that there are no > > > active devices on the same bus segment. The active device tracking is > > > designed to only track host devices that are active in use by guests. > > > This ignores host devices that are actively in use by the host. So the > > > current logic will reset host devices. Hilarity ensues. > > > > > > Switch this logic around and allow sbus reset when we are assigning all > > > devices behind a bridge to the same guest at guest startup or as a result > > > of a single attach-device command. > > > > Okay that looks fine too, I pushed the 4 patches after the small > > changes for tabs. In the future "make syntax-check" helps avoid this :-) > > Great, thanks Daniel. I'm glad to learn about "make syntax-check"...my eye > grep routine sucks at catching space/tab confusion ;-) Bahh just some bad kernel bias, one of Linus early mistake nobody fought enough to get rid of >:-> Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list