Re: [PATCHv2 2/4] Make virStorageBackendCopyToFD return -errno.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 On 07/21/2010 11:12 AM, Daniel Veillard wrote:
On Mon, Jul 19, 2010 at 09:21:53PM -0400, Laine Stump wrote:
Previously virStorageBackendCopyToFD would simply return -1 on
error. This made the error return from one of its callers inconsistent
(createRawFileOpHook is supposed to return -errno, but if
virStorageBackendCopyToFD failed, createRawFileOpHook would just
return -1). Since there is a useful errno in every case of error
return from virStorageBackendCopyToFD, and since the other uses of
that function ignore the return code (beyond simply checking to see if
it is<  0), this is a safe change.
---
  src/storage/storage_backend.c |    9 +++++++--
  1 files changed, 7 insertions(+), 2 deletions(-)

  ACK,

Pushed. Thanks!

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]