On Tue, Jul 20, 2010 at 02:09:30PM +0100, Daniel P. Berrange wrote: > From: Daniel P. Berrange <dan@xxxxxxxxxxxx> > > The first VGA and IDE devices need to have fixed PCI address > reservations. Currently this is handled inline with the other > non-primary VGA/IDE devices. The fixed virtio balloon device > at slot 3, ensures auto-assignment skips the slots 1/2. The > virtio address will shortly become configurable though. This > means the reservation of fixed slots needs to be done upfront > to ensure that they don't get re-used for other devices. > > This is more or less reverting the previous changeset: > > commit 83acdeaf173b2a1206b755c1ab317cac36facd90 > Author: Daniel P. Berrange <berrange@xxxxxxxxxx> > Date: Wed Feb 3 16:11:29 2010 +0000 > > Fix restore of QEMU guests with PCI device reservation > > The difference is that this time, instead of unconditionally > reserving the address, we only reserve the address if it was > initially type=none. Addresses of type=pci were handled > earlier in process by qemuDomainPCIAddressSetCreate(). This > ensures restore step doesn't have problems > > * src/qemu/qemu_conf.c: Reserve first VGA + IDE address > upfront > --- Okay, Just that the 2 new loops replacing the old one are rather different so I had a bit of a hard time following the logic, but looks fine, ACK, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list