Re: [PATCH 04/11] Require format to be passed into virStorageFileGetMetadata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 12, 2010 at 02:30:41PM +0100, Daniel P. Berrange wrote:
> Require the disk image to be passed into virStorageFileGetMetadata.
> If this is set to VIR_STORAGE_FILE_AUTO, then the format will be
> resolved using probing. This makes it easier to control when
> probing will be used
> 
> * src/qemu/qemu_driver.c, src/qemu/qemu_security_dac.c,
>   src/security/security_selinux.c, src/security/virt-aa-helper.c:
>   Set VIR_STORAGE_FILE_AUTO when calling virStorageFileGetMetadata.
> * src/storage/storage_backend_fs.c: Probe for disk format before
>   calling virStorageFileGetMetadata.
> * src/util/storage_file.h, src/util/storage_file.c: Remove format
>   from virStorageFileMeta struct & require it to be passed into
>   method.

  Okay sort of work around for my question on previous patch for most
  cases,

   ACK

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel@xxxxxxxxxxxx  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]