On Fri, Jul 02, 2010 at 11:18:23AM -0400, Chris Lalancette wrote: > Since we are adding a new "per-hypervisor" protocol, we > make it so that the qemu remote protocol uses a new > PROTOCOL and PROGRAM number. This allows us to easily > distinguish it from the normal REMOTE protocol. > > This necessitates changing the proc in remote_message_header > from a "remote_procedure" to an "unsigned", which should > be the same size (and thus preserve the on-wire protocol). For paranoia, we should change to just an 'int' since that's technically what the XDR spec says an enum is http://www.faqs.org/rfcs/rfc1832.html "3.3 Enumerations have the same representation as signed integers." ACK, besides that. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list