On 07/02/2010 07:01 AM, Chris Lalancette wrote: >> >> Do we need to validate that the resulting name is valid (starts with a >> letter, and contains only alphanumeric and _)? arg and env_value can >> obviously be arbitrary strings, but not env_name. > > Hm, interesting, I didn't know that rule about environment variable names. > That is a good check to make, I'll add it. Technically, any string that does not contain = can be inserted as an environment name, but then you can't access them from the shell. So it's best to restrict environment names to portable names (basically, the same set as shell variable names). Also, does the .rng relaxed schema have a way to express the limitation on valid env_names, for your patch 8/8? -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list