On 07/01/2010 02:59 PM, Chris Lalancette wrote:
> Now that we have the ability to specify arbitrary qemu
> command-line parameters in the XML, use it to handle unknown
> command-line parameters when doing a native-to-xml conversion.
>
> Changes since v1:
> - Rename num_extra to num_args
> - Fix up a memory leak on an error path
>
> Signed-off-by: Chris Lalancette <clalance@xxxxxxxxxx>
> ---
> src/qemu/qemu_conf.c | 28 ++++++++++++++++++++++------
> 1 files changed, 22 insertions(+), 6 deletions(-)
>
> diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
> } else {
> - VIR_WARN("unknown QEMU argument '%s' during conversion", arg);
> -#if 0
> - qemuReportError(VIR_ERR_INTERNAL_ERROR,
> - _("unknown argument '%s'"), arg);
> - goto error;
> -#endif
> + /* something we can't yet parse. Add it to the qemu namespace
> + * cmdline/environment advanced options and hope for the best
> + */
Let's still keep the VIR_WARN, as it may help in debugging.
ACK, with that nit addressed.
--
Eric Blake eblake@xxxxxxxxxx +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list