On Fri, Jun 25, 2010 at 09:09:42AM -0400, Laine Stump wrote: > > > >On Fri, Jun 25, 2010 at 07:42:14AM -0400, Laine Stump wrote: > > > >>This code was previously used inline during qemudDomainSaveFlag. This > >>patch moves it into a utility function in preparation for it to be > >>used elsewhere. > >> > >How about just switching to use virStorageFileIsSharedFS() ? > > > > Ah! I either hadn't noticed that function go in, or had forgotten about it. > > One problem I see is that virStorageFileIsSharedFS doesn't traverse back > up the path elements looking for a partial path it can stat. This means > it will fail if the file in question (or any of its ancestor > directories) isn't stat'able by root. > > Any objections to me changing virStorageFileIsSharedFS to behave like that? Sounds reasonable to me Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list