On Fri, Jun 18, 2010 at 03:56:34PM -0400, Stefan Berger wrote: > V2: > - Following Daniel Berrange's suggestions: > - if LIBVIRT_TCK_CONFIG is set, grep for the last occurrence of > "^uri/s*=" and assign the value to LIBVIRT_URI > - check that LIBVIRT_URI is set to qemu:///system, otherwise skip test > - if allowed, remove all VMs and nwfilters starting with tck- > - rename all VMs and nwfilters created by this test program to start > with 'tck-' > - other: > - terminate if sourcing the test-lib.sh from libvirt's tests dir is > missing (would need to be copied) > - redirect stderr to stdout whereever output is read into a variable > > + checkExpectedOutput "${TESTFILTERNAME}" "${TESTVM2FWALLDATA}" \ > + "${vm2name}" "${flags}" "" > + > + if [ $((flags & FLAG_ATTACH)) -ne 0 ]; then > + > + tmpfile=`mktmpfile` > + > + b=`{ ${VIRSH} dumpxml ${vm1name} | tr -d "\n"; echo; } | \ > + sed "s/.*\<interface.*source > bridge='\([a-zA-Z0-9_]\+\)'.*<\/interface>.*/\1/"` Unfortunately your mail client has mangled the patch here and in quite a few other places. Can you re-send with git send-email as its too much to fix up by hand. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list