On 06/22/2010 03:30 PM, Matthias Bolte wrote: > 2010/6/9 Eric Blake <eblake@xxxxxxxxxx>: >> http://bugzilla.redhat.com/601143, part 1 - document existing >> behavior. Ever since Mar 2010 (commit ced154cb), the use of >> 'attach-disk' or 'attach-device' to change cdrom/floppy media has been >> documented but deprecated, but the replacement to use 'update-device' >> was not documented. >> >> * tools/virsh.c (cmdAttachInterface, cmdAttachDisk): Fix bad error >> message. >> * tools/virsh.pod (attach-device, attach-disk): Refer to >> update-device for cdrom and floppy behavior. >> (update-device): Add documentation. >> --- >> tools/virsh.c | 9 ++++++--- >> tools/virsh.pod | 13 ++++++++++++- >> 2 files changed, 18 insertions(+), 4 deletions(-) >> > > ACK. Thanks. This part of the patch was non-controversial, so I've pushed it (to make it easier to justify back-porting along with other documentation cleanups). The second half, adding 'virsh change-disk', will just have to wait for a later day when we have more consensus on how best to represent it. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list