On 06/14/2010 03:46 PM, Jim Meyering wrote: > Eric Blake wrote: >> Daniel's patch works with gcc and CFLAGS containing -O (the >> autoconf default), but fails with non-gcc or with other >> CFLAGS (such as -g), since c-ctype.h declares c_isdigit as >> a macro only for certain compilation settings. >> >> * src/Makefile.am (libvirt_parthelper_LDFLAGS): Add gnulib >> library, for when c_isdigit is not a macro. >> * src/storage/parthelper.c (main): Avoid out-of-bounds >> dereference, noticed by Jim Meyering. > Looks good. > ACK Thanks; I went ahead and pushed both Daniel's and my patch. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list