Re: [PATCH 1/1] Fix leaks in udev device add/remove v3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/07/2010 11:23 AM, David Allan wrote:
> * This patch is a modification of a patch submitted by Nigel Jones.
>   It fixes several memory leaks on device addition/removal:
> 
> 1. Free the virNodeDeviceDefPtr in udevAddOneDevice if the return
>    value is non-zero
> 
> 2. Always release the node device reference after the device has been
>    processed.
> 
> * Refactored for better readability per the suggestion of clalance

Yes, in comparing the two versions, I can see the improvement.  ACK on
this version.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]