Re: [PATCH] build: fix HTML errors in nwfilter docs

[Eduardo Otubo <otubo@xxxxxxxxxxxxxxxxxx>]

On 05/25/2010 08:22 PM, Eric Blake wrote:
> A build on Ubuntu reported:
>
> || Generating formatnwfilter.html.tmp
> /dados/develop/libvirt/docs/formatnwfilter.html.in|390| HTML parser error : Unexpected end tag : p
> ||</p>
> ||         ^
> /dados/develop/libvirt/docs/formatnwfilter.html.in|705| HTML parser error : Unexpected end tag : code
> ||<td>End of range of valid source ports</code></td>
> ||                                                       ^
> /dados/develop/libvirt/docs/formatnwfilter.html.in|710| HTML parser error : Unexpected end tag : code
> ||<td>Start of range of valid destination ports</code></td>
> ||                                                              ^
>
> * docs/formatnwfilter.html.in: Fix invalid HTML constructs.
> Reported by Eduardo Otubo.

Tested on my Ubuntu 10.04.
ACK.

> ---
>
> Don't know why a build on Fedora didn't catch these, so I
> won't push until I get an ack that this fixes things on Ubuntu.
>
>   docs/formatnwfilter.html.in |   11 ++++++-----
>   1 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/docs/formatnwfilter.html.in b/docs/formatnwfilter.html.in
> index f03e9ce..586a4fb 100644
> --- a/docs/formatnwfilter.html.in
> +++ b/docs/formatnwfilter.html.in
> @@ -384,10 +384,11 @@
>         </table>
>       <p>
>         Valid Strings for<code>protocolid</code>  are: arp, rarp, ipv4, ipv6
> -<br><br>
> -      Example:<pre>&lt;mac match='no' srcmacaddr='$MAC'/&gt;</pre>
> -<br><br>
>       </p>
> +<pre>
> +[...]
> +&lt;mac match='no' srcmacaddr='$MAC'/&gt;
> +</pre>
>
>       <h5><a name="nwfelemsRulesProtoARP">ARP/RARP</a></h5>
>       <p>
> @@ -702,12 +703,12 @@
>          <tr>
>            <td>srcportend</td>
>            <td>UINT16</td>
> -<td>End of range of valid source ports</code></td>
> +<td>End of range of valid source ports</td>
>          </tr>
>          <tr>
>            <td>dstportstart</td>
>            <td>UINT16</td>
> -<td>Start of range of valid destination ports</code></td>
> +<td>Start of range of valid destination ports</td>
>          </tr>
>          <tr>
>            <td>dstportend</td>

--
Eduardo Otubo
Software Engineer
Linux Technology Center
IBM Systems & Technology Group
Mobile: +55 19 8135 0885
eotubo@xxxxxxxxxxxxxxxxxx

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list