On 05/25/2010 10:42 AM, Eric Blake wrote: > On 05/24/2010 12:52 PM, Cole Robinson wrote: >> + >> + /* Need to sanitize: >> + * // -> // >> + * /// -> / >> + * /../foo -> /../foo >> + * /.//foo -> /foo >> + * /foo///bar/ -> /foo/bar >> + * ./foo/./. -> /foo >> + */ >> + > > For my second attempt at a valid review, I actually compiled the > function, and threw the above inputs at it. /../foo -> /./foo (oops, > didn't match documentation), and ./foo/./. -> /foo (oops, matched > documentation, but turned a relative path into absolute), so we do need > a v4, but not for the original reasons in my first NAK where I mis-read > the do-while loop. > Thanks for the review, I'll fix that case and repost. - Cole -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list