On Fri, May 21, 2010 at 11:21:34AM -0600, Eric Blake wrote: > On 05/21/2010 09:28 AM, Cole Robinson wrote: > >> Any interest in doing this with netlink instead? (I've got this "thing" > >> against parsing text files to get information if it can be retrieved via > >> a nice clean API). If so, I think I can whip up the equivalent code with > >> libnl calls, but probably not until later in the afternoon. > >> > >> If I'm the only one who feels uneasy about parsing stuff out of /proc, > >> then I'm fine with that too. > >> > > > > My feeling is it depends on what else libnl buys us. A library > > dependency for a single safety check doesn't seem worth it. If we use > > the lib, we definitely don't want it to be optional, as debugging > > network issues in the future shouldn't require asking 'is libvirt > > compiled against libnl'. > > Stefan just posted a patch series that would also add a dependency on > libnl for vepa; as long as we are using the library, we might as well > use it for more than one thing. We already depend on it via netcf in any case. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list