On 05/21/2010 09:29 AM, Jim Fehlig wrote: > > This and your other comments are addressed in V3. > > V3: > - Check for overflow in virBitmapAlloc > - Fix copy and paste bug in virBitmapAlloc > - Use size_t in prototypes > - Add ATTRIBUTE_NONNULL in prototypes where appropriate > and remove NULL check form impl If you keep that as part of the commit message, s/form/from/ (Personally, I put my comments about intra-version diffs... > --- ...here, after the --- (by using git send-email --annotate), so that they are part of the email trail but not the actual commit message. After all, at the end of the day, the email trail shows how we got the the end result, but the commit history need only show the end result if we aren't committing the intermediate results. But aside from my nitpicking on the commit message, the patch itself looks good! ACK. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list