On 05/20/2010 02:49 PM, Jim Meyering wrote:
>> ACK to 1/2, but let's respin 2/2 to tweak daemonForkIntoBackground to
>> take another parameter...
>
> Um...
> Well there are two other diagnostics with no progname: prefix.
> They're in qemudWritePidFile:
>
> VIR_ERROR(_("Failed to write to pid file '%s' : %s")
> VIR_ERROR(_("Failed to close pid file '%s' : %s")
>
> so rather than adding parameters to two functions, I'll add a global,
> argv0, and *remove* a few parameters:
Adding the global is nice. I had to go look at VIR_ERROR (forwards to
virLogMessage, which in turn prints a timestamp but does not print
argv0) to make sure that it made sense to add argv0 there. So,
ACK.
--
Eric Blake eblake@xxxxxxxxxx +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list