On 05/20/2010 10:12 AM, Chris Lalancette wrote:
On 05/20/2010 01:06 AM, Charles Duffy wrote:
On 05/19/2010 11:54 PM, Charles Duffy wrote:
A revised patch is attached. This lifts its logic from its kernel
counterpart, and is updated only to permit forward slashes (which, while
disallowed for interface names with the kernel, are required for
*device* names -- for which the ESX driver happens to overload this
field. Ugh).
Hm. You know, I'm wondering if we should have "isValidIfname" at all in
domain_conf.c. The thing is that if you think about different platforms
that this could be running on (Windows, Linux, Solaris, etc), and the
number of different drivers that go through here (Qemu, Xen, ESX, Virtualbox,
Phyp, openvz, ONE, UML), it seems like we have to allow everything to
cover all bases. Indeed, there is very little else in domain_conf.c that
does validity checking, probably for just this reason.
Charles, Laine, what do you think about just removing this check completely?
interface_conf.c also parses interface names, and has no validity
checking - anything inside the quotes is acceptable. So yeah, I have no
problem with not having a check.
(All this talk about valid characters has me thinking about the plethora
of websites that have validity checkers for email addresses that don't
allow "+". Grrr.)
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list