On Thu, Mar 20, 2025 at 04:17:00PM -0600, Jim Fehlig via Devel wrote: > Commits c2518f7bc7 and 28a0621528 introduced build failures on 32-bit > platforms by using incorrect format specifiers with g_strdup_printf. > > In one case, an 'unsigned long' format specifier is used with a > 'long long int' variable. Fix by changing the format specifier to > 'uintmax_t', and casting the variable likewise. > > In a second case, an 'unsigned long' format specifier is used with a > 'size_t' variable, which is 'unsigned int' on 32-bit systems. Fix by > changing the format specifier to use the 'z' modifier. > > Fixes: c2518f7bc7dd4f8ab8655a12ec3a000e1eb5b232 > Fixes: 28a06215280b99708ed8dc2d183f62ba7b34ccf8 > Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx> > --- > > A lot of ways to skin this cat, but I think this would be the > preferred approach. And while adding the 2 'Fixes:' lines to the > commit message, I questioned whether this should be 2 patches. > > src/qemu/qemu_monitor.c | 4 ++-- > src/qemu/qemu_process.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
