On Sun, Mar 16, 2025 at 12:18:21 +0400, marcandre.lureau--- via Devel wrote: > From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> > Marc-André Lureau (20): > build-sys: drop -Winline when optimization=g > build: fix -Werror=maybe-uninitialized > qemu-slirp: drop unneeded check for OOM > util: annotate non-null arguments for virGDBusCallMethod() > qemu: add rdp state directory > qemu: add qemu RDP configuration > conf: parse optional RDP username & password > conf: generalize virDomainDefHasSpiceGraphics > qemu: use virDomainDefHasGraphics > qemu: add RDP ports range allocator > qemu: limit to one <graphics type='rdp'> > qemu/virtiofs: use domainLogContext > qemu/dbus: keep a connection to the VM D-Bus > qemu/dbus: log daemon stdout/err, use domainLogContext > qemu: validate RDP configuration > qemu: add qemu-rdp helper unit > qemu: pass virQEMUDriverConfig to capabilities > qemu: add 'rdp' capability if qemu-rdp is available > qemu: add RDP support > tests: add qemu <graphics type='rdp'/> test This most likely broke upstream CI. I noticed the following when debugging something else locally: $ valgrind --trace-children=yes --leak-check=full ./tests/qemuxmlconftest =1007397== 5 bytes in 1 blocks are definitely lost in loss record 10 of 849 ==1007397== at 0x4841866: malloc (vg_replace_malloc.c:446) ==1007397== by 0x591EC0F: xmlStrndup (in /usr/lib64/libxml2.so.2.12.9) ==1007397== by 0x495C4D4: virDomainGraphicsAuthDefParseXML (domain_conf.c:11530) ==1007397== by 0x4971A8F: virDomainGraphicsDefParseXMLRDP (domain_conf.c:11926) ==1007397== by 0x4971A8F: virDomainGraphicsDefParseXML (domain_conf.c:12229) ==1007397== by 0x49903C5: virDomainDefParseXML (domain_conf.c:19665) ==1007397== by 0x4991FD8: virDomainDefParseNode (domain_conf.c:20260) ==1007397== by 0x49920E0: virDomainDefParse (domain_conf.c:20230) ==1007397== by 0x11FB54: testQemuConfXMLCommon.constprop.0 (qemuxmlconftest.c:683) ==1007397== by 0x1210D5: testXMLParse (qemuxmlconftest.c:981) ==1007397== by 0x121819: virTestRun (testutils.c:143) ==1007397== by 0x121AA0: virTestRunLog (testutils.c:198) ==1007397== by 0x10B371: testRun (qemuxmlconftest.c:1022) ==1007397== ==1007397== 5 bytes in 1 blocks are definitely lost in loss record 11 of 849 ==1007397== at 0x4841866: malloc (vg_replace_malloc.c:446) ==1007397== by 0x591EC0F: xmlStrndup (in /usr/lib64/libxml2.so.2.12.9) ==1007397== by 0x495C4F7: virDomainGraphicsAuthDefParseXML (domain_conf.c:11535) ==1007397== by 0x4971A8F: virDomainGraphicsDefParseXMLRDP (domain_conf.c:11926) ==1007397== by 0x4971A8F: virDomainGraphicsDefParseXML (domain_conf.c:12229) ==1007397== by 0x49903C5: virDomainDefParseXML (domain_conf.c:19665) ==1007397== by 0x4991FD8: virDomainDefParseNode (domain_conf.c:20260) ==1007397== by 0x49920E0: virDomainDefParse (domain_conf.c:20230) ==1007397== by 0x11FB54: testQemuConfXMLCommon.constprop.0 (qemuxmlconftest.c:683) ==1007397== by 0x1210D5: testXMLParse (qemuxmlconftest.c:981) ==1007397== by 0x121819: virTestRun (testutils.c:143) ==1007397== by 0x121AA0: virTestRunLog (testutils.c:198) ==1007397== by 0x10B371: testRun (qemuxmlconftest.c:1022) ==1007397== ==1007397== 5 bytes in 1 blocks are definitely lost in loss record 12 of 849 ==1007397== at 0x4841866: malloc (vg_replace_malloc.c:446) ==1007397== by 0x591EC0F: xmlStrndup (in /usr/lib64/libxml2.so.2.12.9) ==1007397== by 0x495C4D4: virDomainGraphicsAuthDefParseXML (domain_conf.c:11530) ==1007397== by 0x4971A8F: virDomainGraphicsDefParseXMLRDP (domain_conf.c:11926) ==1007397== by 0x4971A8F: virDomainGraphicsDefParseXML (domain_conf.c:12229) ==1007397== by 0x49903C5: virDomainDefParseXML (domain_conf.c:19665) ==1007397== by 0x4991FD8: virDomainDefParseNode (domain_conf.c:20260) ==1007397== by 0x49920E0: virDomainDefParse (domain_conf.c:20230) ==1007397== by 0x11FFE7: testCompareOutXML2XML (qemuxmlconftest.c:782) ==1007397== by 0x121819: virTestRun (testutils.c:143) ==1007397== by 0x121AA0: virTestRunLog (testutils.c:198) ==1007397== by 0x10B39D: testRun (qemuxmlconftest.c:1024) ==1007397== by 0x111C1A: mymain (qemuxmlconftest.c:1756) ==1007397== ==1007397== 5 bytes in 1 blocks are definitely lost in loss record 13 of 849 ==1007397== at 0x4841866: malloc (vg_replace_malloc.c:446) ==1007397== by 0x591EC0F: xmlStrndup (in /usr/lib64/libxml2.so.2.12.9) ==1007397== by 0x495C4F7: virDomainGraphicsAuthDefParseXML (domain_conf.c:11535) ==1007397== by 0x4971A8F: virDomainGraphicsDefParseXMLRDP (domain_conf.c:11926) ==1007397== by 0x4971A8F: virDomainGraphicsDefParseXML (domain_conf.c:12229) ==1007397== by 0x49903C5: virDomainDefParseXML (domain_conf.c:19665) ==1007397== by 0x4991FD8: virDomainDefParseNode (domain_conf.c:20260) ==1007397== by 0x49920E0: virDomainDefParse (domain_conf.c:20230) ==1007397== by 0x11FFE7: testCompareOutXML2XML (qemuxmlconftest.c:782) ==1007397== by 0x121819: virTestRun (testutils.c:143) ==1007397== by 0x121AA0: virTestRunLog (testutils.c:198) ==1007397== by 0x10B39D: testRun (qemuxmlconftest.c:1024) ==1007397== by 0x111C1A: mymain (qemuxmlconftest.c:1756)
