Re: [PATCH v2 20/22] admin: add 'daemon-shutdown' command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 13, 2025 at 02:18:18PM +0100, Peter Krempa wrote:
> On Wed, Mar 12, 2025 at 17:18:00 +0000, Daniel P. Berrangé wrote:
> > The daemons are wired up to shutdown in responsible to UNIX process
> > signals, as well as in response to login1 dbus signals, or loss of
> > desktop session. The latter two options can optionally preserve state
> > (ie running VMs).
> > 
> > In non-systemd environments, as well as for testing, it would be useful
> > to have a way to trigger shutdown with state preservation more directly.
> > 
> > Thus a new admin protocol API is introduced
> > 
> >   virAdmConnectDaemonShutdown
> > 
> > which will trigger a daemon shutdown, and preserve running VMs if the
> > VIR_DAEMON_SHUTDOWN_PRESERVE flag is set.
> > 
> > It has a corresponding 'virt-admin daemon-shutdown [--preserve]' command
> > binding.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> > ---
> >  docs/manpages/virt-admin.rst        | 13 +++++++++
> >  include/libvirt/libvirt-admin.h     | 13 +++++++++
> >  src/admin/admin_protocol.x          | 11 +++++++-
> >  src/admin/admin_server_dispatch.c   | 13 +++++++++
> >  src/admin/libvirt-admin.c           | 33 +++++++++++++++++++++++
> >  src/admin/libvirt_admin_public.syms |  5 ++++
> >  tools/virt-admin.c                  | 41 +++++++++++++++++++++++++++++
> >  7 files changed, 128 insertions(+), 1 deletion(-)

This one lacks changes to the admin protocol structs file

Now my other series implementing "ninja regen-admin_protocol" is
merged, I've re-generated the structs file for this

> 
> Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux