On Thu, Mar 13, 2025 at 15:26:52 +0100, Peter Krempa wrote: > On Thu, Mar 13, 2025 at 14:44:35 +0100, Michal Privoznik wrote: > > There are some members of the virCHDomainObjPrivate struct that > > are allocated at various stages of domain lifecycle but then are > > never freed: > > > > 1) cgroup - allocated in virDomainCgroupSetupCgroup() > > 2) autoCpuset - this one is actually never allocated (and thus is > > always NULL, but soon it may be used. Just free > > it for now, which is a NOP anyways. > > 3) autoNodeset - same story as 2). > > So wait; was it copied from qemu without being used? > > Will it actually be used soon? If no; I'd prefer to just delete the > members instead. Ah I see that it's actually at least attempted to be read. So ignore this and Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>
