Re: [PATCH v2 17/22] rpc: move state stop into virNetDaemon class

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 12, 2025 at 17:17:57 +0000, Daniel P. Berrangé wrote:
> Currently the remote daemon code is responsible for calling virStateStop
> in a background thread. The virNetDaemon code wants to synchronize with
> this during shutdown, however, so the virThreadPtr must be passed over.
> 
> Even the limited synchronization done currently, however, is flawed and
> to fix this requires the virNetDaemon code to be responsible for calling
> virStateStop in a thread more directly.
> 
> Thus the logic is moved over into virStateStop via a further callback
> to be registered by the remote daemon.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> ---
>  src/libvirt_remote.syms    |  2 +-
>  src/remote/remote_daemon.c | 40 ++------------------------
>  src/rpc/virnetdaemon.c     | 59 +++++++++++++++++++++++++++++++-------
>  src/rpc/virnetdaemon.h     | 27 +++++++++++++++--
>  4 files changed, 77 insertions(+), 51 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux