Hi On Thu, Mar 13, 2025 at 1:07 PM Martin Kletzander <mkletzan@xxxxxxxxxx> wrote: > > On Thu, Mar 13, 2025 at 11:59:41AM +0400, Marc-André Lureau wrote: > >Hi > > > >On Tue, Mar 11, 2025 at 5:28 PM Martin Kletzander <mkletzan@xxxxxxxxxx> wrote: > >> So I tried testing it and I found a couple of issues. Those might be on > >> my side, maybe caused by misunderstanding of it all. First of all > >> <graphics type='dbus'/> fails with these patches for me even without > > > >How does it fail? (it works on my end) > > > > $ virsh dumpxml fedora39 --xpath //graphics > <graphics type="dbus"/> > <graphics type="spice" autoport="yes"> > <listen type="address"/> > <image compression="off"/> > </graphics> > > $ virsh version > Compiled against library: libvirt 11.1.0 > Using library: libvirt 11.1.0 > Using API: QEMU 11.1.0 > Running hypervisor: QEMU 9.2.2 > > $ virsh start fedora39 > Domain 'fedora39' started > > $ virsh destroy fedora39 > Domain 'fedora39' destroyed > > $ echo 'Start daemon with patches' > Start daemon with patches > $ virsh version > Compiled against library: libvirt 11.1.0 > Using library: libvirt 11.1.0 > Using API: QEMU 11.1.0 > Running hypervisor: QEMU 9.2.2 > > $ # Same version, but this time with the patch series applied > $ virsh dumpxml fedora39 --xpath //graphics > <graphics type="dbus"/> > <graphics type="spice" autoport="yes"> > <listen type="address"/> > <image compression="off"/> > </graphics> > > $ virsh start fedora39 > error: Failed to start domain 'fedora39' > error: operation failed: Failed to connect to dbus-daemon: The connection is closed Hmm, I don't get this issue. libvirt fails to connect to the just launched bus (or got closed). This is weird, because we checked earlier the socket exists. Could you check dbus log? (for some reason it's not in cfg.logDir, but in cfg.dbusStateDir - I wonder if we can change that now) thanks