> On Thu, Feb 20, 2025 at 11:35:01AM -0000, honglei.wang(a)smartx.com wrote: > > The first approach can be rewritten to the second one and is only an > easier to write way. I would suggest we use the second one and we can > add a functionality which will rewrite the first one to the second one > upon definition. To make it easier to unplug we could, theoretically, > see if the disk is the only namespace of the controller and unplug that, > but that's just a nice-to-have, I guess. Yes, the latter is more general, and I agree that unifying to the second approach makes sense. I will submit another patch that only includes the second approach. As for hot-unplugging behavior, we can optimize it in the future if needed, as Martin mentioned.
