Re: [PATCH v2 01/11] qemu: Use modern header formatting in 'qemu_command.h'

[Ján Tomko <jtomko@xxxxxxxxxx>]

On a Monday in 2025, Peter Krempa wrote:
> The file used intermixed style. Convert the last outliers to the new
> formatting style.
>
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
> src/qemu/qemu_command.h | 85 ++++++++++++++++++++++++-----------------
> 1 file changed, 50 insertions(+), 35 deletions(-)
>
> diff --git a/src/qemu/qemu_command.h b/src/qemu/qemu_command.h
> index 76c514b5f7..7c891a6c98 100644
> --- a/src/qemu/qemu_command.h
> +++ b/src/qemu/qemu_command.h
> @@ -40,31 +40,37 @@
> VIR_ENUM_DECL(qemuVideo);
> VIR_ENUM_DECL(qemuSoundCodec);
>
> -virCommand *qemuBuildCommandLine(virDomainObj *vm,
> -                                 const char *migrateURI,
> -                                 virDomainMomentObj *snapshot,
> -                                 virNetDevVPortProfileOp vmop,
> -                                 size_t *nnicindexes,
> -                                 int **nicindexes);
> +virCommand *
> +qemuBuildCommandLine(virDomainObj *vm,
> +                     const char *migrateURI,
> +                     virDomainMomentObj *snapshot,
> +                     virNetDevVPortProfileOp vmop,
> +                     size_t *nnicindexes,
> +                     int **nicindexes);
>
> /* Generate the object properties for pr-manager */
> -virJSONValue *qemuBuildPRManagerInfoProps(virStorageSource *src);
> -virJSONValue *qemuBuildPRManagedManagerInfoProps(qemuDomainObjPrivate *priv);
> +virJSONValue *
> +qemuBuildPRManagerInfoProps(virStorageSource *src);
> +virJSONValue *
> +qemuBuildPRManagedManagerInfoProps(qemuDomainObjPrivate *priv);
>
> -virJSONValue *qemuBuildDBusVMStateInfoProps(virQEMUDriver *driver,
> -                                              virDomainObj *vm);
> +virJSONValue *
> +qemuBuildDBusVMStateInfoProps(virQEMUDriver *driver,
> +                              virDomainObj *vm);
>
> /* Generate the object properties for a secret */
> -int qemuBuildSecretInfoProps(qemuDomainSecretInfo *secinfo,
> -                             virJSONValue **propsret);
> +int
> +qemuBuildSecretInfoProps(qemuDomainSecretInfo *secinfo,
> +                         virJSONValue **propsret);
>
> /* Generate the object properties for a tls-creds-x509 */
> -int qemuBuildTLSx509BackendProps(const char *tlspath,
> -                                 bool isListen,
> -                                 bool verifypeer,
> -                                 const char *alias,
> -                                 const char *secalias,
> -                                 virJSONValue **propsret);
> +int
> +qemuBuildTLSx509BackendProps(const char *tlspath,
> +                             bool isListen,
> +                             bool verifypeer,
> +                             const char *alias,
> +                             const char *secalias,
> +                             virJSONValue **propsret);
>
> /* Open a UNIX socket for chardev FD passing */
> int

Here,
 qemuOpenChrChardevUNIXSocket(const virDomainChrSourceDef *dev) G_NO_INLINE;
still has the G_NO_INLINE attribute annotation on the same line

> @@ -254,6 +265,10 @@ qemuBuildTPMOpenBackendFDs(const char *tpmdev,
>                            int *cancelfd)
>     ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3) G_NO_INLINE;
>
> -const char * qemuAudioDriverTypeToString(virDomainAudioType type);
> -virDomainAudioType qemuAudioDriverTypeFromString(const char *str);
> -int qemuVDPAConnect(const char *devicepath) G_NO_INLINE;
> +const char *
> +qemuAudioDriverTypeToString(virDomainAudioType type);
> +virDomainAudioType
> +qemuAudioDriverTypeFromString(const char *str);
> +
> +int
> +qemuVDPAConnect(const char *devicepath) G_NO_INLINE;

Same here.

Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature